fix: preserve undefined in deep accessor types#6239
Open
cyphercodes wants to merge 1 commit intoTanStack:mainfrom
Open
fix: preserve undefined in deep accessor types#6239cyphercodes wants to merge 1 commit intoTanStack:mainfrom
cyphercodes wants to merge 1 commit intoTanStack:mainfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fixes #6238 by preserving
undefinedinDeepValuewhen a deep string accessor traverses an optional parent key. This keepsrow.getValue()typed asnumber | undefinedfor paths likeuser.salary.amountwhensalaryis optional.Added a table-core type regression test for the optional deep accessor case.
✅ Checklist
pnpm test:pr.Targeted checks run locally:
pnpm --filter @tanstack/table-core test:typespnpm --filter @tanstack/table-core buildpnpm --filter @tanstack/table-core test:libpnpm exec prettier --check packages/table-core/src/utils.ts packages/table-core/tests/columnHelper.test-d.ts packages/table-core/tsconfig.test-d.json packages/table-core/package.json .changeset/quiet-bears-protect.mdgit diff --check🚀 Release Impact